[vlc-devel] [PATCH] Properly detect POSIX threads on OpenBSD.

[Brad]

On Friday 12 June 2009 19:49:51 Brad wrote:
> On Thursday 11 June 2009 16:32:58 Rémi Denis-Courmont wrote:
> > Le jeudi 11 juin 2009 23:09:12 Brad, vous avez écrit :
> > > The following diff for VLC 1.0.0rc3 corrects the detection of POSIX
> > > threads on OpenBSD.
> >
> > This checks for main in -lpthread but adds -pthread. Looks like this will
> > break conformant OSes (that use -lpthread instead of -pthread).
>
> bah. please revert this commit. the end result was what I wanted (adding
> -pthread) but the test is incorrect. although we (OpenBSD) do have
> libpthread and the flag that should be used is -pthread the test is
> incorrect in that it should actually be attempting to compile a binary with
> the compiler using the -pthread flag and ensuring that is successful.

Still trying to get this reverted and I noticed what was commited is different 
from what I sent in and even more broken.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.