[vlc-devel] commit: No need to create an object to handle the lock is such a simple case. ( Rémi Duraffort )
ivoire at videolan.org
Thu Jun 18 14:50:29 CEST 2009
> > No need to create an object to handle the lock is such a simple case.
> I don't really see the rationnal behind that change, the solution with the
> object has 0 cost (cpu/memory, as long as the compilator is not uterly dumb).
> It is a common practice with c++ and mandatory(?) with exceptions.
I thought that creating an object will add an overhead. As I'm not at
all an expert of C++ I will trust you (and revert).
Does it change something to the perf to have a virtual destructor ?
> > #define ROOMSIZE_TEXT N_("Room size")
> > #define ROOMSIZE_LONGTEXT N_("Defines the virtual surface of the room" \
> > - "emulated by the filter." )
> > + "emulated by the filter." )
> > #define WIDTH_TEXT N_("Room width")
> > #define WIDTH_LONGTEXT N_("Width of the virtual room")
> > @@ -90,21 +90,6 @@ struct aout_filter_sys_t
> > };
> But way worse, do NOT mix (especially large) cosmetics with code modifications.
> It make non cosmetics modifications harder to revert.
Sorry for this part I will avoid this in the future.
Rémi Duraffort | ivoire
More information about the vlc-devel