[vlc-devel] commit: Never print the password in the logs. ( Rémi Duraffort )

[git version control]

vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Fri Jun 19 11:14:36 2009 +0200| [ec01f1da2483121e609fa771aad3ad834f1c7004] | committer: Rémi Duraffort 

Never print the password in the logs.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ec01f1da2483121e609fa771aad3ad834f1c7004
---

 modules/access/http.c        |    9 +--------
 modules/access/rtmp/access.c |    3 +--
 modules/access_output/rtmp.c |    3 +--
 modules/demux/live555.cpp    |    3 +--
 4 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/modules/access/http.c b/modules/access/http.c
index d6cb633..234a249 100644
--- a/modules/access/http.c
+++ b/modules/access/http.c
@@ -452,14 +452,7 @@ connect:
                       p_sys->auth.psz_realm );
         if( psz_login != NULL && psz_password != NULL )
         {
-            msg_Dbg( p_access, "retrying with user=%s, pwd=%s",
-                     psz_login,
-#if 1
-                     "yeah right, like we're going to print a password."
-#else
-                     psz_password
-#endif
-                );
+            msg_Dbg( p_access, "retrying with user=%s", psz_login );
             p_sys->url.psz_username = psz_login;
             p_sys->url.psz_password = psz_password;
             Disconnect( p_access );
diff --git a/modules/access/rtmp/access.c b/modules/access/rtmp/access.c
index 57e9238..a8613db 100644
--- a/modules/access/rtmp/access.c
+++ b/modules/access/rtmp/access.c
@@ -128,8 +128,7 @@ static int Open( vlc_object_t *p_this )
 
     if( p_sys->p_thread->url.psz_username && *p_sys->p_thread->url.psz_username )
     {
-        msg_Dbg( p_access, "      user='%s', pwd='%s'",
-                 p_sys->p_thread->url.psz_username, p_sys->p_thread->url.psz_password );
+        msg_Dbg( p_access, "      user='%s'", p_sys->p_thread->url.psz_username );
     }
 
     /* Initialize thread variables */
diff --git a/modules/access_output/rtmp.c b/modules/access_output/rtmp.c
index b0937d7..eac532b 100644
--- a/modules/access_output/rtmp.c
+++ b/modules/access_output/rtmp.c
@@ -136,8 +136,7 @@ static int Open( vlc_object_t *p_this )
 
     if( p_sys->p_thread->url.psz_username && *p_sys->p_thread->url.psz_username )
     {
-        msg_Dbg( p_access, "      user='%s', pwd='%s'",
-                 p_sys->p_thread->url.psz_username, p_sys->p_thread->url.psz_password );
+        msg_Dbg( p_access, "      user='%s'", p_sys->p_thread->url.psz_username );
     }
 
     /* Initialize thread variables */
diff --git a/modules/demux/live555.cpp b/modules/demux/live555.cpp
index ae1dd9b..9287f83 100644
--- a/modules/demux/live555.cpp
+++ b/modules/demux/live555.cpp
@@ -620,8 +620,7 @@ describe:
                         _("Please enter a valid login name and a password.") );
             if( psz_user != NULL && psz_pwd != NULL )
             {
-                msg_Dbg( p_demux, "retrying with user=%s, pwd=%s",
-                         psz_user, psz_pwd );
+                msg_Dbg( p_demux, "retrying with user=%s", psz_user );
                 goto describe;
             }
         }