[vlc-devel] RE : [PATCH] -- a module_unneed is missing for Windowsand MacOS ports

[brezhoneg1]

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Derk-Jan Hartman
> Envoyé : lundi 15 juin 2009 12:54
> À : Mailing list for VLC media player developers
> Objet : [Bulk] Re: [vlc-devel] [PATCH] -- a module_unneed is missing
for
> Windowsand MacOS ports
> 
> On 15 jun 2009, at 12:37, brezhoneg1 wrote:
> > In 1.0-bugfix, Windows(skins2 only) and MacOS(likely) run their GUI
> > interface in the main thread. In their code path, the module_unneed
> > for
> > the interface is never called.
> >
> > For Windows(skins2), this can lead to a crash at termination.
> >
> > This patch just adds the missing module_unneed before releasing the
> > object.
> > Yet, It needs MacOS devs to also validate it since this may cause
> > regression for them.
> 
> 
> Confirmed. Please apply.
> 

Actually, my previous patch was not the best solution to the missing
"module_unneed". It may even lead to problems.

At this early stage of vlc termination, a input/vout may still be
running. Fully releasing the GUI interface may be a problem for a vout
thread.

It may be better to just remove "vlc_object_detach" and
vlc_object_release" for the interface obj (patch attached). In this
case, they still get released in the loop releasing all interfaces later
on in the code path (after the playlist is deactivated).
 
Anybody on the MacOS dev side to confirm/comment this email?

Erwan10
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-make-sure-not-to-release-the-interface-module-before.patch
Type: application/octet-stream
Size: 904 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090620/dd9eb9c5/attachment.obj>