[vlc-devel] commit: FIx a segfault: we need both user and password to be not NULL. ( R??mi Duraffort )

jpd at videolan.org jpd at videolan.org
Mon Jun 22 09:07:42 CEST 2009


On Mon, Jun 22, 2009 at 07:55:07AM +0200, git version control wrote:
> -    if( p_sys->url.psz_username || p_sys->url.psz_password )
> +    if( p_sys->url.psz_username && p_sys->url.psz_password )

Are there cases to handle only username and only password? Silently
ignoring one when the other isn't present sounds like a good way to
frustrate users. Perhaps fill in "" for an empty username or password?




More information about the vlc-devel mailing list