[vlc-devel] commit: a missing module_unneed is added (Windows and MacOS ports) ( Erwan Tulou )

[Rémi Denis-Courmont]

Le lundi 15 juin 2009 15:12:25 git version control, vous avez écrit :
> vlc | branch: 1.0-bugfix | Erwan Tulou <erwan10 at videolan.org> | Mon Jun 15
> 13:21:25 2009 +0200| [a8a020758902d9b6333f8b6f88895412efd9dffe] |
> committer: Erwan Tulou
>
> a missing module_unneed is added (Windows and MacOS ports)
>
> On Windows, it hopefully solves crashes at termination for skins2
>
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a8a020758902d9b633
> >3f8b6f88895412efd9dffe
>
> ---
>
>  src/interface/interface.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/interface/interface.c b/src/interface/interface.c
> index c48986a..284e38f 100644
> --- a/src/interface/interface.c
> +++ b/src/interface/interface.c
> @@ -147,6 +147,8 @@ int intf_RunThread( intf_thread_t *p_intf )
>          vlc_thread_join( p_intf );
>
>          vlc_object_detach( p_intf );
> +        if( p_intf->p_module )
> +            module_unneed( p_intf, p_intf->p_module );
>          vlc_object_release( p_intf );

Uh, please unload BEFORE detaching, otherwise pf_close cannot use 
var_CreateGet*().

-- 
Rémi Denis-Courmont
http://www.remlab.net/