[vlc-devel] commit: Force new not to throw. Also drop a separate declaration of a static function that' s called exactly once, and mark it inline instead. (JP Dinger )

Rémi Denis-Courmont remi at remlab.net
Mon Jun 22 19:38:48 CEST 2009


Le lundi 22 juin 2009 20:13:20 jpd at videolan.org, vous avez écrit :
> On Mon, Jun 22, 2009 at 07:57:04PM +0300, R?mi Denis-Courmont wrote:
> > You're visibly leaking a lock here. Maybe some other stuff.
>
> Fixed in the very next commit. The standing alternative was a throw
> back into C code, though. Take your pick.

I don't care... I just happen to review commits in chronological order. My 
short-term memory stack space is very finite, so that recursively unwinding 
review is not really an option.

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list