[vlc-devel] RE : commit: a missing module_unneed is added (Windowsand MacOS ports) ( Erwan Tulou )

[Rémi Denis-Courmont]

Le lundi 22 juin 2009 22:06:33 brezhoneg1, vous avez écrit :
> > Uh, please unload BEFORE detaching, otherwise pf_close cannot use
> > var_CreateGet*().
>
> Okay, I can do it.
>
> Just one point, wouldn't it be better to simply remove this block
> (module_unneed, vlc_object_detach, vlc_object_release)?
>
> At this point in the code, the playlist is not yet deactivated and an
> input may still be running. Fully releasing the interface may lead to
> problems with a vout thread.

That seems like a good point (I don't use any of the affected platforms).
We already do that in 1.1, I think/hope.

> In addition, by just removing them in this part of the code, they will
> "naturally" be called later on in the termination process (in the loop
> releasing all interfaces after the playlist is deactivated).
>
> I tested it successfully on Windows(skins). But, MacOS devs also need to
> agree on this.
>
> Your advice ?

Fine with me, but I cannot test anyway.

-- 
Rémi Denis-Courmont
http://www.remlab.net/