[vlc-devel] RE : [Bulk] Re: RE : commit: a missing module_unneed is added(Windowsand MacOS ports) ( Erwan Tulou )

[brezhoneg1]

> >
> > That seems like a good point (I don't use any of the affected
> > platforms).
> > We already do that in 1.1, I think/hope.


Checked. There is no problem in 1.1


> >
> Tested the following, which I based on master, and it seemed to have
> no adverse affects.
> 
> diff --git a/src/interface/interface.c b/src/interface/interface.c
> index 284e38f..0f258da 100644
> --- a/src/interface/interface.c
> +++ b/src/interface/interface.c
> @@ -141,15 +141,8 @@ int intf_RunThread( intf_thread_t *p_intf )
>           RunInterface( VLC_OBJECT(p_intf) );
> 
>           /* Make sure our MonitorLibVLCDeath thread exit */
> -        vlc_object_kill( p_intf );
>           /* It is monitoring libvlc, not the p_intf */
>           vlc_object_kill( p_intf->p_libvlc );
> -        vlc_thread_join( p_intf );
> -
> -        vlc_object_detach( p_intf );
> -        if( p_intf->p_module )
> -            module_unneed( p_intf, p_intf->p_module );
> -        vlc_object_release( p_intf );
>           return VLC_SUCCESS;
>       }
>   #endif
> 

I guess vlc_object_kill/vlc_object_join can be kept, as it just means
cleaning up the extra MonitorLibVLCDeath thread if any. Since
termination has started, this thread is no longer needed anyway.


Erwan10