[vlc-devel] commit: Use add_password instead of add_string when applicable. ( Rémi Duraffort )

[Rémi Denis-Courmont]

On Tue, 23 Jun 2009 14:13:35 +0200, Rémi Duraffort <ivoire at videolan.org>
wrote:
>> > Use add_password instead of add_string when applicable.
>> >
>> > CERT_LONGTEXT, diff --git a/modules/access/ftp.c
> b/modules/access/ftp.c
>> > index b3dc2c9..b2d692d 100644
>> > --- a/modules/access/ftp.c
>> > +++ b/modules/access/ftp.c
>> > @@ -79,8 +79,8 @@ vlc_module_begin ()
>> >          change_safe()
>> >      add_string( "ftp-user", "anonymous", NULL, USER_TEXT,
> USER_LONGTEXT,
>> >                  false )
>> > -    add_string( "ftp-pwd", "anonymous at example.com", NULL, PASS_TEXT,
>> > -                PASS_LONGTEXT, false )
>> > +    add_password( "ftp-pwd", "anonymous at example.com", NULL,
> PASS_TEXT,
>> > +                  PASS_LONGTEXT, false )
>> 
>> IMHO, the default value does not make much sense anymore with this
> commit...
> Yes you'r right. Maybe we can set the default value to NULL and give the
> default value (anonymous at example.com) as an example in the long string ?

We need a sane default, otherwise anonymous FTP will not work out of the
box anymore.

Arguably, HTTP and FTP user and password options should be marked as
volatile and not shown in the UI at all. Then the issue is moot. It does
not make much sense to save credentials FOR ALL SERVERS of a given
protocol.

That sort of thing should really be passed through the CLI or through the
URL per input items. At the same time, we should mark those "safe" for
playlists.

-- 
Rémi Denis-Courmont