[vlc-devel] [PATCH] Add marq filter to libvlc

Pierre d'Herbemont pdherbemont at free.fr
Tue Jun 23 20:16:20 CEST 2009

On Tue, Jun 23, 2009 at 5:22 AM, Cyril
MATHE<cmathe at actech-innovation.com> wrote:
> Hello,
> This is the new patch for marq. One function is added:
> libvlc_marq_set_option(libvlc_marq_option_t, int i_val, char *psz_text)
> It enables, disables or sets a marq option.

I am sorry for being to clear enough here... I don't think having two
arguments for the setter is a good idea. I'd like the idea that the
getter is straight forward to implement.

Moreover a const char* should be used here.

To be more specific:
libvlc_marq_set_option_as_int(libvlc_marq_int_option_t, int val);
libvlc_marq_set_option_as_string(libvlc_marq_string_option_t, const
char * string);

char * libvlc_marq_get_option_as_string(libvlc_marq_string_option_t);
int libvlc_marq_get_option_as_int(libvlc_marq_int_option_t);

Should be the way to go in my opinion.


More information about the vlc-devel mailing list