[vlc-devel] commit: XSPF: remove harmful base decoding ( Rémi Denis-Courmont )

Rafaël Carré rafael.carre at gmail.com
Tue Jun 23 22:02:30 CEST 2009


On Tue, 23 Jun 2009 21:57:26 +0200 (CEST)
git at videolan.org (git version control) wrote:

> vlc | branch: 1.0-bugfix | Rémi Denis-Courmont <remi at remlab.net> |
> Tue Jun 23 22:56:36 2009 +0300|
> [9d3fbd002c9aff5136dfaadf323635828f2b4505] | committer: Rémi
> Denis-Courmont 
> 
> XSPF: remove harmful base decoding
> 
> (cherry picked from commit 993d4fcc4a511fc1b5d3bc3cafb262dd20e5cf40)
> 
> Conflicts:
> 
> 	modules/demux/playlist/xspf.c

..

> @@ -546,21 +546,18 @@ static bool parse_track_node COMPLEX_INTERFACE
>                  /* special case: location */
>                  if( !strcmp( p_handler->name, "location" ) )
>                  {
> -                    char *psz_location = psz_value;
> -                    if( !strncmp( psz_value, "file://", 7 ) )
> -                        psz_location = decode_URI( psz_value + 7 );
> -
> -                    if( !psz_location )
> -                    {
> -                        FREE_ATT();
> -                        return false;
> -                    }
> -
> +                    /* FIXME: This is broken. Scheme-relative

This does a bit more than what the commit log says, you could have
mentioned it at least, and also the commit where it was introduced.

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090623/050f242b/attachment.sig>


More information about the vlc-devel mailing list