[vlc-devel] commit: input_item_SetURI(): add a NDEBUG printf check for paths. ( Derk-Jan Hartman )

Rémi Denis-Courmont remi at remlab.net
Wed Jun 24 17:07:28 CEST 2009


Le mercredi 24 juin 2009 17:24:00 git version control, vous avez écrit :
> --- a/src/input/item.c
> +++ b/src/input/item.c
> @@ -353,6 +353,10 @@ char *input_item_GetURI( input_item_t *p_i )
>  void input_item_SetURI( input_item_t *p_i, const char *psz_uri )
>  {
>      vlc_mutex_lock( &p_i->lock );
> +#ifndef NDEBUG
> +    if( !strstr( psz_uri, "://" || strstr( psz_uri, " " ) || strstr(
> psz_uri, "\") ))
> +        fprintf( stderr, "input_item_SetURI() was likely
> called with a path. FIXME\n" );
> +#endif

Why do you need the item lock for this check?

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list