[vlc-devel] commit: Process key action immediately, kill the hotkey thread ( Rémi Denis-Courmont )

git version control git at videolan.org
Thu Jun 25 21:53:01 CEST 2009

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Jun 25 22:44:29 2009 +0300| [d9361832b9580f8a24c4c9585a86ede02cbfa0a1] | committer: Rémi Denis-Courmont 

Process key action immediately, kill the hotkey thread

This saves memory, diminishes latency and fixes an unlikely loss of
events if too many actions are sent. This may expose some re-entrancy
bugs, although I did some succesful smoke tests. Any path that emits a
key action or a key press needs to be careful. vout_thread_t.pf_manage
is the most obvious case. That should be safe as the vout thread holds
no locks when in pf_manage. Not sure about OpenGL though.

A small bug with SPU across vout change remains present as before.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d9361832b9580f8a24c4c9585a86ede02cbfa0a1

 modules/control/hotkeys.c |  232 +++++++++++++++++---------------------------
 1 files changed, 90 insertions(+), 142 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=d9361832b9580f8a24c4c9585a86ede02cbfa0a1

More information about the vlc-devel mailing list