[vlc-devel] [PATCH] Add marq filter to libvlc

Pierre d'Herbemont pdherbemont at free.fr
Mon Jun 29 06:21:37 CEST 2009


I've committed something with some modifications.

Looking at the implementation it looks like a vout is required for
every operation. This is certainly not what you want, because most of
the time the vout is not yet around. And it also mean the setting is
not persistent. Please look at the "drawable" implementation, if you
want to see how persistent settings can be achieved.

Pierre.

On Thu, Jun 25, 2009 at 11:19 PM, Pierre
d'Herbemont<pdherbemont at gmail.com> wrote:
>
> On Jun 24, 2009, at 2:17 AM, Cyril MATHE wrote:
>
> Hello,
>
> I am sorry for being to clear enough here... I don't think having two
>
> arguments for the setter is a good idea. I'd like the idea that the
>
> getter is straight forward to implement.
>
> Moreover a const char* should be used here.
>
> To be more specific:
>
> libvlc_marq_set_option_as_int(libvlc_marq_int_option_t, int val);
>
> libvlc_marq_set_option_as_string(libvlc_marq_string_option_t, const
>
> char * string);
>
> char * libvlc_marq_get_option_as_string(libvlc_marq_string_option_t);
>
> int libvlc_marq_get_option_as_int(libvlc_marq_int_option_t);
>
> Should be the way to go in my opinion.
>
> Pierre.
>
> It's partly my fault, I was not sure, I sould ask before. I was thinking
> that there was too much code lines repeat. Now it's exactly like you
> want it to be. The patch is joined to this email.
>
> Best Regards,
> Cyril
> <0010-libvlc-API-Add-Marquee-Filter-to-libvlc-in-video.c.patch>_______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
>



More information about the vlc-devel mailing list