[vlc-devel] [PATCH] Use character classes instead of ranges in check_headers.

[Rémi Denis-Courmont]

On Mon, 29 Jun 2009 11:56:42 +0200, jpd at videolan.org wrote:
> On Mon, Jun 29, 2009 at 11:27:08AM +0200, Alexis Ballier wrote:
>> LC_COLLATE in my en_US utf8 locale orders characters with 'aAbB...zZ',
>> therefore const is, unexpectedly, in [A-Z]*.
>> If your sed does not exhibit this behavior, please try with sed 4.2.1.
> 
> gnu sed (there are non-gnu seds Out There) 4.1.5 comes with a manpage
> that claims [A-Z] assumes locale C, but a cursory search indicates that
> at least SUSv2 requires LC_COLLATE to be used.
> 
> Alright, this sounds reasonable but I think that if we expect C locale
> then we might as well set LC_ALL=C at the top of our scripts.

No. First I see no reason to disable locale support on a systematic basis.
Second, this would fail to override more specific locale variables. In this
particular case, we should just set character type and collation to POSIX.

-- 
Rémi Denis-Courmont