[vlc-devel] commit: Remove enums from public APIs ( Rémi Denis-Courmont )

[Pierre d'Herbemont]

Remi,

I wouldn't call this the correct way to do it. We loose too much
information here.

A wiser way, in my opinion is to do:

enum enum_name {
   blah
}
typedef unsigned enum_name;
void function(enum_name param);

This makes the API much more understandable, and could allow some type
checking with checkers.

I put my weight so this gets reverted.

Pierre.

On Mon, Jun 29, 2009 at 8:38 AM, git version control<git at videolan.org> wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Jun 29 18:38:32 2009 +0300| [3d0ef0165c1c9189192d6f7dad3fd5901db6034c] | committer: Rémi Denis-Courmont
>
> Remove enums from public APIs
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3d0ef0165c1c9189192d6f7dad3fd5901db6034c
> ---
>
>  include/vlc/libvlc_events.h            |    6 ++--
>  include/vlc/libvlc_media.h             |   18 ++++++++--------
>  include/vlc/libvlc_media_list_player.h |    2 +-
>  include/vlc/libvlc_media_player.h      |   34 ++++++++++++++++----------------
>  src/control/media.c                    |   12 ++++------
>  src/control/media_internal.h           |    4 +-
>  src/control/media_list_player.c        |    6 +++-
>  src/control/media_player.c             |   18 ++++++++--------
>  src/control/mediacontrol_core.c        |    2 +-
>  src/control/video.c                    |    8 +++---
>  10 files changed, 55 insertions(+), 55 deletions(-)
>
> Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=3d0ef0165c1c9189192d6f7dad3fd5901db6034c
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>