[vlc-devel] [PATCH] RTMP handshake compliance for clients

[Kevin DuBois]

As per the RTMP spec (available here, http://www.adobe.com/devnet/rtmp/ )
the handshake implementation is currently slightly wrong.

(Page 12)
The spec says that the 2nd round of packets need to have the 1st 4 bytes be
the timestamp (potentially zero) and the next 4 bytes be zero. The bytes
after that should be random. (not necessarily cryptographically secure, just
for establishing a unique echo response in the 3rd round of packets).

The current implementation sent the 2nd round of packets to be bytes
incrementing from 0x00 to 0xff. This patch resolves it.

This was causing issues specifically connecting to Wowza media server. Apply
patch to modules/access/rtmp/rtmp_amf_flv.c

If anyone can recommend a test RTMP stream for me to verify, (one that they
know is already working) that would be great.


Cheers,
Kevin DuBois
kdub432 at gmail.com
PGP fingerprint
80CF 7C1D 0A1C BE03 2203
95B6 1515 C3DC B6BE 7E88
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090629/1920422d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtmp_compliance.patch
Type: text/x-patch
Size: 662 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090629/1920422d/attachment.bin>