[vlc-devel] RE : [PATCH] -- libvlc_playlist_play in bin/winvlc.c

[Rémi Denis-Courmont]

Le lundi 29 juin 2009 21:56:29 brezhoneg1, vous avez écrit :
> > À : vlc-devel at videolan.org
> > Objet : Re: [vlc-devel] [PATCH] -- libvlc_playlist_play in
>
> bin/winvlc.c
>
> > Le lundi 29 juin 2009 02:02:33 brezhoneg1, vous avez écrit :
> > > Is it okay to apply this patch (attachment) ? any better idea ?
> >
> > Should this not rather be fixed in the playlist code?
>
> Ideally, this should be fixed in bin/(win)vlc.c. Blocking on a
> libvlc_AddIntf was not originally part of the design. For Windows(skins)
> and MacOS, the libvlc_playlist_play call which is meant to start
> playback is executed when vlc terminates !
>
> Maybe, adding a libvlc_is_alive( instance ) to the API and use it to
> limit calling libvlc_playlist_play when it makes sense would be a
> cleaner way.

I am very much against adding another hackish API to libvlc, especially 1.1.

The playlist is supposed to cope with this gracefully anyway. On top of that, 
the playlist functions have all been deprecated except for _play. Then, we 
should try to do something useful with the main thread on non-broken 
interfaces; and that would spell the death of libvlc_wait() and 
libvlc_playlist_play(). Waiting on a condition variable for the entire 
lifetime of VLC is _not_ useful. Lastly, the playlist API is supposed to be 
deprecated.

-- 
Rémi Denis-Courmont
http://www.remlab.net/