[vlc-devel] [PATCH] Rewrite Quartztext to use CoreText, not ATSUI

Derk-Jan Hartman hartman at videolan.org
Tue Jun 30 16:09:12 CEST 2009


On 28 jun 2009, at 07:14, bernie.purcell at chilli.net.au wrote:
> Remove all ATSUI calls from Quartztext, as it is a deprecated API,  
> and not compatible with 64-bit applications. Add code to make use of  
> CoreText API instead, which does work with 64-bit apps, but requires  
> a minimum of Mac OS X 10.5.
> This is still a Carbon module, not Cocoa. No effort made to  
> conditionally compile module to use ATSUI for older versions of OS  
> X, but easy enough to do with ifdefs if required.
> Module is working for me at the moment, but needs wider testing  
> prior to commit due to large number of changes. Also need decision  
> on what we want to support with this module.

I've done a quick test and it seems to work pretty well. The only  
problem i see is that for "simple" rendering it doesn't set any  
outline atm. That makes it difficult to read the subs on white  
background video. I see no need for ATSUI backwards compatibility, our  
minimum OS version for 1.0 and later is 10.5

The Compose() etc will need a good review, because we had scaling  
issues there last time as well and those are bad. We should also  
really make an effort to bring back the background effects and outline  
effects, but that can be done at a later time.

DJ



More information about the vlc-devel mailing list