[vlc-devel] commit: Call XInitThreads early enough ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

Le dimanche 1 mars 2009 13:51:03 git version control, vous avez écrit :
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Mar  1
> 13:41:46 2009 +0200| [364868f96ff0d745905fec4b9df35942fd8c0d7b] |
> committer: Rémi Denis-Courmont
>
> Call XInitThreads early enough

P.S.:

If you don't want VLC to depend on libX11 directly, you're welcome to find a 
better solution, and/or help with the XCB port.

Simply calling XInitThreads from a few select plugins won't cut it:
 - All plugins that may depend directly or _indirectly_ on Xlib must
   call XInitThreads.
 - XInitThreads is not re-entrant. It's OK to call it multiple times
   sequentially, but not simultaneously. The first call must succeed
   before subsequent ones.

P.P.S.: If you maintain a application that uses Xlib and LibVLC, yet it does 
not call XInitThreads, you are *screwed* and I am sorry for you. This may 
affect JVLC and vlc-cil, although I don't know.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary