[vlc-devel] commit: missing strdup (Geoffroy Couprie )

[Jean-Baptiste Kempf]

On Thu, Mar 05, 2009 at 04:53:24PM +0100, Geoffroy Couprie wrote :
> On Thu, Mar 5, 2009 at 4:21 PM, Geoffroy Couprie <geo.couprie at gmail.com> wrote:
> > On Thu, Mar 5, 2009 at 3:56 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> >>
> >> On Thu,  5 Mar 2009 15:26:27 +0100 (CET), git at videolan.org (git version
> >> control) wrote:
> >>> vlc | branch: master | Geoffroy Couprie <geal at videolan.org> | Thu Mar  5
> >>> 15:24:15 2009 +0100| [867836628fd4f4959aac18f0af819f0c611410fa] |
> >>> committer: Geoffroy Couprie
> >>>
> >>> missing strdup
> >>
> >> Err, const char * = strdup... something is wrong in this commit.
> >>
> >
> > hmm, yes, the commit is wrong. But when I try to add a podcast url, it
> > stores random characters in config, instead of my url. Any idea?
> >
> 
> I think I found it: the string pointed by the returned value of qtu is
> valid as long as the QString is valid (and here, url is valid as long
> as the podcast configuration dialog is). So, I need a strdup.

But do you need a const?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/