[vlc-devel] [PATCH] Make libvlc_set_drawable hwnd aware

[basos g]

2009/3/6 Rémi Denis-Courmont <rem at videolan.org>:
> Le vendredi 6 mars 2009 11:35:19 basos g, vous avez écrit :
>> 2009/3/6 Jean-Baptiste Kempf <jb at videolan.org>:
>> > On Fri, Mar 06, 2009 at 09:20:27AM +0000, basos g wrote :
>> >> +#ifdef __WIN32__
>> >> +    p_mi->drawable.hwnd = drawable ;
>> >> +#else
>> >>      p_mi->drawable.xid = drawable;
>> >> -
>> >> +#endif
>> >
>> > Could you try to be consistent with other ifdefs?
>> >
>> > I think most of the code uses WIN32 or _WIN32 (better, IIRC)
>>
>> You, re right.
>> Corrected
>
> Storing an integer to a pointer... cough cough.
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
You are right. I didn't see the drawable_t type.

But why not upgrade drawable_t to long long (64 bit integer) to be
able to store 32/64 bit window handles?

The current status of libvlc is kindof ugly.
There are 3 functions for the drawable stuff :
set_hwnd
set_xid
set_drawable


If the above modification is possible the we should leave out the 2 first.
Or if someone says that we can't break the API and we should keep
set_drawable, i say better break it and make a clean design.


But IMO set_drawable should be the only function to set the drawing
surface handle. It is more clean. Now i have to conditionally compile
libvlc applications.