[vlc-devel] [PATCH] VOUT FIX snapshot lock, add new debug msgs

[basos g]

2009/3/6 Rémi Denis-Courmont <rem at videolan.org>:
> Le vendredi 6 mars 2009 11:22:38 basos g, vous avez écrit :
>> Snapshot callback now locks vout_change lock before changing b_snapshot.
>> NOTE: This is a temp fix in the sense that vout_snapshot should not
>> burden vout thread, that is time critical.
>> Also debug messages are added to make clues about :
>> a) the clock issue ( see VLC timing issues on ML)
>> b) the rgb chroma issue ( see VLC RBG chroma issues on ML)
>
> And what protects b_snapshot? I don't understand how that fixes the earlier
> problems.
>
> --
> Rémi Denis-Courmont
> http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
Could you be more specific ? What do you mean "who protects b_snapshot" .

Now there is a modification to a vout variable whithout locking.
Of course with the current impl there no thing like snapshot queue
(for not to miss a snapshot ) .

But this issue, as we have discussed before, should be totally
addressed by a redesign of the snapshot code.