[vlc-devel] [PATCH] Make libvlc_set_drawable hwnd aware

[basos g]

2009/3/7 Rémi Denis-Courmont <rem at videolan.org>:
> Le samedi 7 mars 2009 12:51:16 basos g, vous avez écrit :
>> You are right. I didn't see the drawable_t type.
>>
>> But why not upgrade drawable_t to long long (64 bit integer) to be
>> able to store 32/64 bit window handles?
>
> Depending on the calling conventions, this could break the ABI on some
> non-32-bits X11-based platforms (drawable_t is always big enough for an XID).
>
>> If the above modification is possible the we should leave out the 2 first.
>> Or if someone says that we can't break the API and we should keep
>> set_drawable, i say better break it and make a clean design.
>
>> But IMO set_drawable should be the only function to set the drawing
>> surface handle. It is more clean. Now i have to conditionally compile
>> libvlc applications.
>
> I disagree and I don't want to have this discussion again for the third time
> in 2 months.
>
> --
> Rémi Denis-Courmont
> http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>

Well,

I am satisfied with
http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c2eea782021026a4df45f0e2b828cef1970b37aa

However, I didn't understand the ABI breakage issue as long as 32 bits
would fit in a long long integer value.

But man please don't just say "its totaly wrong, end of conversation".
Some people just have other opinions.