[vlc-devel] [PATCH] VOUT FIX snapshot lock, add new debug msgs

Laurent Aimar fenrir at via.ecp.fr
Sun Mar 8 14:22:30 CET 2009

On Sat, Mar 07, 2009, Rémi Denis-Courmont wrote:
> Le samedi 7 mars 2009 12:57:11 basos g, vous avez écrit :
> > > And what protects b_snapshot? I don't understand how that fixes the
> > > earlier problems.
> > Could you be more specific ? What do you mean "who protects b_snapshot" .
> To be pedantic, I would like to know what is the memory synchronization scheme 
> ensuring well-defined use of the b_snapshot parameter.
> I might be missing something, but it seems you're acquiring the change_lock on 
> one side, but not on the other side. I don't understand your rationale. Why 
> don't you acquire the change_lock everywhere?
 It is acquired on both side, but it is not visible unless you look at
src/video_output/video_output.c directly.


More information about the vlc-devel mailing list