[vlc-devel] [PATCH] -- more small patches for a better skins2

brezhoneg1 brezhoneg1 at yahoo.fr
Mon Mar 9 01:41:53 CET 2009


 

Please find more patches that will help skins2 to terminate in a cleaner
way


Patch1: qt4 issue (as dialog provider)
A tricky bug. A global variable is used to store a p_input that is meant
to be local and it is not reset to NULL. Result is that p_input is
released a second time at destruction of the object (when skins
terminates), and an assert fails.

This patch changes it into a local variable.

Patch2 : freetype
Freetype holds twice the object (a vlc_object_find + vlc_object_hold in
the same function). Count is wrong when vlc terminates.

This patch removes vlc_object_hold.

Patch3 :qt4 menus.cpp
A vlc_object_hold without a vlc_object_release. Patch already sent but
wasn't acked.
Just sending it again as a reminder that a correction is needed one way
or another.



Erwan10

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-qt4-in-main-input-manager-a-static-variable-is-use.patch
Type: application/octet-stream
Size: 996 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090309/5c1d0d89/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-freetype.patch
Type: application/octet-stream
Size: 774 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090309/5c1d0d89/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-qt4-in-menus.cpp-missing-vlc_object_release.patch
Type: application/octet-stream
Size: 767 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090309/5c1d0d89/attachment-0002.obj>


More information about the vlc-devel mailing list