[vlc-devel] [PATCH] -- more small patches for a better skins2

[Rémi Denis-Courmont]

Le lundi 9 mars 2009 02:41:53 brezhoneg1, vous avez écrit :
> Patch1: qt4 issue (as dialog provider)
> A tricky bug. A global variable is used to store a p_input that is meant
> to be local and it is not reset to NULL. Result is that p_input is
> released a second time at destruction of the object (when skins
> terminates), and an assert fails.
>
> This patch changes it into a local variable.

There is a much more fundamental problem there. The code cannot pass p_input 
to the Qt4 inputChanged signal at all here. There is no warranty that the 
given pointer is still valid when the signal is delivered, since 
vlc_object_release() is called immediately afterward, and the connection is 
non-blocking.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary