[vlc-devel] RE : [PATCH] -- skins2 (more corrections)

[brezhoneg1]

> 
> I must say that...
> 
>      if( !b_playlist_locked ) PL_UNLOCK;
> 
> +
> +    if( b_playlist_locked ) PL_UNLOCK;
> 
> ...that smells utmostly fishy to me.
> 

The function playlist_CurrentInput( ) automatically holds the playlist.
Since this lock may already be held before entering the function, this
results in EDEADLCK(35).

Maybe a recursive lock would solve this issue ? 

What I did was to quickly overcome the problem by unlocking just before
and relocking just after, but I agree this should not be the long term
solution.

Erwan10