[vlc-devel] commit: ncurses: fix object leak and use pl_Release instead of vlc_object_release. ( Rémi Duraffort )

git version control git at videolan.org
Fri Mar 20 10:46:21 CET 2009


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Fri Mar 20 09:21:09 2009 +0100| [b5619a2ffec95e440ff4b6150b0b715057d03f1c] | committer: Rémi Duraffort 

ncurses: fix object leak and use pl_Release instead of vlc_object_release.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b5619a2ffec95e440ff4b6150b0b715057d03f1c
---

 modules/gui/ncurses.c |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/modules/gui/ncurses.c b/modules/gui/ncurses.c
index 7d96fee..06b59db 100644
--- a/modules/gui/ncurses.c
+++ b/modules/gui/ncurses.c
@@ -554,13 +554,13 @@ static int HandleKey( intf_thread_t *p_intf, int i_key )
 
     #define ReturnTrue \
     do { \
-    vlc_object_release( p_playlist ); \
+    pl_Release( p_intf ); \
     return 1; \
     } while(0)
 
     #define ReturnFalse \
     do { \
-    vlc_object_release( p_playlist ); \
+    pl_Release( p_intf ); \
     return 0; \
     } while(0)
 
@@ -2212,7 +2212,7 @@ static void Redraw( intf_thread_t *p_intf, time_t *t_last_refresh )
     refresh();
 
     *t_last_refresh = time( 0 );
-    vlc_object_release( p_playlist );
+    pl_Release( p_intf );
 }
 
 static playlist_item_t *PlaylistGetRoot( intf_thread_t *p_intf )
@@ -2229,7 +2229,7 @@ static playlist_item_t *PlaylistGetRoot( intf_thread_t *p_intf )
         default:
             p_item = p_playlist->p_root_onelevel;
     }
-    vlc_object_release( p_playlist );
+    pl_Release( p_intf );
     return p_item;
 }
 
@@ -2250,7 +2250,7 @@ static void PlaylistRebuild( intf_thread_t *p_intf )
 
     PL_UNLOCK;
 
-    vlc_object_release( p_playlist );
+    pl_Release( p_intf );
 }
 
 static void PlaylistAddNode( intf_thread_t *p_intf, playlist_item_t *p_node,
@@ -2314,7 +2314,7 @@ static int PlaylistChanged( vlc_object_t *p_this, const char *psz_variable,
     playlist_t *p_playlist = pl_Hold( p_intf );
     p_intf->p_sys->b_need_update = true;
     p_intf->p_sys->p_node = playlist_CurrentPlayingItem(p_playlist) ? playlist_CurrentPlayingItem(p_playlist)->p_parent : NULL;
-    vlc_object_release( p_playlist );
+    pl_Release( p_intf );
     return VLC_SUCCESS;
 }
 
@@ -2389,7 +2389,7 @@ static void Eject( intf_thread_t *p_intf )
     if( playlist_CurrentPlayingItem(p_playlist) == NULL )
     {
         PL_UNLOCK;
-        vlc_object_release( p_playlist );
+        pl_Release( p_intf );
         return;
     }
 
@@ -2449,6 +2449,7 @@ static void Eject( intf_thread_t *p_intf )
 
     if( psz_device == NULL )
     {
+        pl_Release( p_intf );
         return;
     }
 
@@ -2472,7 +2473,7 @@ static void Eject( intf_thread_t *p_intf )
     }
 
     free( psz_device );
-    vlc_object_release( p_playlist );
+    pl_Release( p_intf );
     return;
 }
 
@@ -2610,7 +2611,7 @@ static void PlayPause( intf_thread_t *p_intf )
     else
         playlist_Play( p_playlist );
 
-    vlc_object_release( p_playlist );
+    pl_Release( p_intf );
 }
 
 /****************************************************************************




More information about the vlc-devel mailing list