[vlc-devel] [PATCH] GSM WAV demux support

Laurent Aimar fenrir at via.ecp.fr
Sat Mar 28 16:15:36 CET 2009

On Sat, Mar 28, 2009, Srikanth Raju wrote:
>    Hello,
>    2009/3/27 Rémi Denis-Courmont <[1]rem at videolan.org>
>             Hello,
>      Le Thursday 26 March 2009 19:42:19 Srikanth Raju, vous avez écrit :
>      > Patch adds GSM support for wav demuxer.
>      >
>      > Can someone review this? The audio plays choppily on my system but not
>      > always. At any rate, its not 100% fine.
>      > Test wav at: [2]http://trac.videolan.org/vlc/ticket/1974
>      Please remove the dummy debug statements and resubmit. Thanks in
>      advance.
>    Revised patch attached. Thanks!
 Merged by [aaddb130d42824b0f63e48059efd1c2829a30dac].

 As a remark, you should have checked against values that come from the
file (untrusted) that could create a problem (in your case you divide by
the bitrate).
 But the wav demuxer code in itself was a really bad example, as no check was
done. The next commit fixes all the missing checks I could see (including the
one for GSM).

The sample attached to #1974 works perfectly here :)

Thanks for your work.


More information about the vlc-devel mailing list