[vlc-devel] [PATCH] GSoC: Expand SDs and MTP functionalities

[Rémi Duraffort]

Hi,

> +services_discovery_t * playlist_ServiceDiscoveryGetById( playlist_t *p_playlist,
> +                                                       int i_id )
> +{
> +    int i;
> +    PL_LOCK;
> +
> +    for( i = 0 ; i< pl_priv(p_playlist)->i_sds ; i ++ )
> +    {
> +        if( i_id == pl_priv(p_playlist)->pp_sds[i]->p_cat->i_id ||
> +            i_id == pl_priv(p_playlist)->pp_sds[i]->p_one->i_id )
> +        {
> +            PL_UNLOCK;
> +            return pl_priv(p_playlist)->pp_sds[i]->p_sd;
> +        }
> +    }
> +    PL_UNLOCK;
> +    return NULL;
> +}
> +
I'm not sure that's a good idea to PL_UNLOCK and then use
pl_priv(p_playlist)->pp_sds[i]


Best regards.

-- 
Rémi Duraffort | ivoire