[vlc-devel] commit: Do not use only one vlc_cond_t for bidirectionnal signaling. ( Laurent Aimar )

[Rémi Denis-Courmont]

On Sat, 28 Mar 2009 12:27:00 +0100 (CET), git at videolan.org (git version
control) wrote:
> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Sat Mar 28
> 12:02:18 2009 +0100| [5a8f7c856b146478dbe85767124e2a6e2760d51e] |
> committer: Laurent Aimar
> 
> Do not use only one vlc_cond_t for bidirectionnal signaling.

A simpler but uglier and slower solution would have been to broadcast a
single condition.
My point is not to suggest a crappier solution but...

> It fixes at least a deadlock in win32 when seeking.

...IIRC, our vlc_cond_signal() always broadcasts condition variables on
Windows, so the deadlock should not have showed up on _that_ particular
platform. I might be missing something here, but that smells fishy.

-- 
Rémi Denis-Courmont