[vlc-devel] [PATCH] --snapshot-format option always fallbacks to png fix
dionoea at videolan.org
Tue Mar 31 10:48:52 CEST 2009
On Sun, Mar 29, 2009, christophe courtaut wrote:
> This patch fixes the fact that snapshot was always taken in png format
> because --snapshot-format option was not working.
> In fact, the --snapshot-format option is taking either png or jpg ( as
> shown in the help ), but to check this format,
> vlc was using image_Ext2Fourrc function which one is waiting for
> parameters such a filename ( ex : "image.jpg" ) to get the format.
> I wrote a function image_Type2Fourcc, which one work with the
> extension only, and so on refactored the function image_Ext2Fourcc
> not to duplicate code.
Looks good to me. I'll apply it when I get back home unless someone
beats me to it.
More information about the vlc-devel