[vlc-devel] [PATCH] Chorus Flanger audio filter

[Srikanth Raju]

Hey,
Sorry about the delay. Changes made and attached.

2009/4/17 Rémi Denis-Courmont <rem at videolan.org>

>        Hello,
>
> Le mardi 7 avril 2009, Srikanth Raju a écrit :
> > I've attached a basic chorus/flanger audio filter. Need some feedback
> > for it.
>
> I'm not very knowledgeable on audio filtering. However, you should:
>  - remove dead debugging code, especially with swear words,
>  - not include header files you really don't need (errno, ctype, signal)
>  - not alter the filter object when Open() returns VLC_EGENERIC.
>  - not leak p_sys when Open() fails.
>  - remove the useless if(p_sys) in Close().
>
> Best regards,
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>



-- 
Regards,
Srikanth Raju
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090508/b1aa1a0d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Chorus-Flanger-audio-filter.patch
Type: text/x-patch
Size: 13029 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090508/b1aa1a0d/attachment.bin>