[vlc-devel] [PATCH] SQL Media Library

[Laurent Aimar]

Hi,

On Sat, May 09, 2009, Jean-Philippe Andr� wrote:
> Some of you already know that I have worked with a few other fellow
> students from ECP last year on a SQL-based Media Library for VLC.
> As 1.0.0 is now a bugfixes branch, it seems to be time for us to merge
> this work in Git trunk.
> 
> I have prepared 3 patches and if there are no strong objections against
> it, I will apply them:
> http://people.via.ecp.fr/~jpeg/VideoLAN/ml-patches/
> 
> I'm not asking you to review the code, because it's too much, but I
> don't want to apply something that big without asking ;-)

 Well applying non clean code is really a bad idea in the long run.
I would really prefer that the code is reviewed and then applied if clean,
especially with new module API.

 As a general remark, the patchs used way too much defines where simple functions
or inlines functions would be cleaner and safer.

 Adding doxygen comment to vlc_sql.h is also needed (at least).

 I can propose myself to review the patchs once the above remarks are
corrected if you want.

Regards,

-- 
fenrir