[vlc-devel] [PATCH] vobsub idx in mkv track CodecPrivate data

John Stebbins stebbins at jetheaddev.com
Tue May 12 22:01:59 CEST 2009

On 05/12/2009 11:07 AM, Laurent Aimar wrote:
> I would really prefer if this code (the palette parsing) is moved to a
> modules/demux/vobsub.h (an inline function is perfect) and so be reused
> by avformat, matroska and vobsub.c.
>   Duplicating code is always a bad idea in the long term.
>   Other than that, it seems fine, thanks for your work.
Something like this perhaps?  Added malloc check and created separate 
vobsub idx parsing functions in new vobsub.h

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Vobsub-palette-mkv.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090512/fc04d428/attachment.ksh>

More information about the vlc-devel mailing list