[vlc-devel] commit: Fixed osd_* functions when the OSD was not loaded. (Laurent Aimar )

Rémi Denis-Courmont remi at remlab.net
Sun May 17 08:55:20 CEST 2009


Le dimanche 17 mai 2009 00:25:09 git version control, vous avez écrit :
> vlc | branch: 1.0-bugfix | Laurent Aimar <fenrir at videolan.org> | Sat May 16
> 23:22:01 2009 +0200| [6dce48f670a1d404fa09898d6e97562d9944c239] |
> committer: Laurent Aimar
>
> Fixed osd_* functions when the OSD was not loaded.
>
>  It fixed a segfault when using hotkeys for the OSD.
>  I am not sure it is perfectly fine, but var_AcquireMutex seems
> to have been removed without a proper replacement.

var_AcquireMutex() took a process-wide lock. That can now be achieved with a 
static mutex directly.

In this particular case, I guess OSD needs a per-instance lock, so 
var_AcquireMutex() would be overkill, and var_Get(p_libvlc) is good.

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list