[vlc-devel] [PATCH] WinCE: remove call to unsupported getcwd()

Pierre Ynard linkfanel at yahoo.fr
Mon May 18 16:44:54 CEST 2009


> > WinCE doesn't support working directories at all, so don't even try...
> > Compile-tested only
> 
> Please stop putting ifdefs all over the place, write proper replacement
> functions...

What exactly do you want me to replace? There's nothing even remotely
similar to getcwd() on WinCE. I can pretend and write a dummy getcwd()
for WinCE that returns a constant, but that seems to me semantically
very broken. Maybe you would prefer a HAVE_GETCWD macro that skips this
altogether?

Do you suggest that ifdefs used to work around missing POSIX functions
(especially on broken platforms like WinCE which cause a lot of them)
should be replaced by wrappers in compat/ ? If so I understand, but this
one doesn't really qualify since the whole functionality is just
unavailable, and cannot be reimplemented.

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."



More information about the vlc-devel mailing list