[vlc-devel] [PATCH] Handle VLM events in libvlc

[Laurent Aimar]

On Tue, May 19, 2009, Rémi Denis-Courmont wrote:
> Le mardi 19 mai 2009 12:55:39 Sébastien Escudier, vous avez écrit :
> > Hi
> >
> > Please see included patch.
> > Some self comments about it :
> >
> > @@ -63,6 +63,7 @@ struct libvlc_instance_t
> >  {
> >      libvlc_int_t *p_libvlc_int;
> >      vlm_t        *p_vlm;
> > +    libvlc_event_manager_t * p_event_manager;
> >
> >
> > -> I did not find a better place to put this event manager. I am open to
> > suggestions.
> 
> In vlm_t perhaps?
 I do not agree. vml_t does not use libvlc_event_manager_t at all, it is
only used by libvlc wrapper and as such belong to it.

> 
> > @@ -208,6 +214,33 @@ typedef struct libvlc_event_t
> >          {
> >              libvlc_time_t   new_length;
> >          } media_player_length_changed;
> > +
> > +        /* VLM media */
> > +        struct
> > +        {
> > +            const char * psz_media_name;
> > +        } vlm_media_added;
> > +
> > +        struct
> > +        {
> > +            const char * psz_media_name;
> > +        } vlm_media_removed;
> > [...]
> >
> > -> As they all have the same variable (psz_media_name), should I create
> > only one structure and use it for all libvlc_VlmMedia* events ?
> 
> I think so.
 Dunno, it does not seems the philosphy of the current way libvlc_event_t
is filled. As it is an union it does not create any memory usage anyway. 
But as I do not use libvlc API, I can't really comment.

-- 
fenrir