[vlc-devel] commit: Adjust: thread-safety ( Rémi Denis-Courmont )

Rémi Denis-Courmont remi at remlab.net
Tue May 19 21:04:43 CEST 2009


Le mardi 19 mai 2009 21:05:07 Rémi Denis-Courmont, vous avez écrit :
> Absolutely every single of the video filters with variable callback were
> buggy, except -perhaps- for the remote OSD. I have not checked the
> subdirectories. This is ridiculous.

By the way, there is still a small race. If the callback variable is 
externally modified between var_(Create)Get and var_AddCallback, the value is 
typically lost. The previous value will be used until the variable is reset 
yet another time. This can happen because the filters are already attached to 
the object tree when they are initialized (otherwise variables and 
configuration items inheritance would not work).

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list