[vlc-devel] commit: macosx: fixed 'Codec details pane does not work correctly', closes #2630 ( Felix Paul Kühne )

[git version control]

vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Wed May 20 12:52:43 2009 +0200| [40b48c5a3a18ef8776073a96394796e93f5c53ee] | committer: Felix Paul Kühne 

macosx: fixed 'Codec details pane does not work correctly', closes #2630

Signed-off-by: Felix Paul Kühne <fkuehne at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=40b48c5a3a18ef8776073a96394796e93f5c53ee
---

 modules/gui/macosx/intf.m |   21 ++++++++++++---------
 1 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
index d411dc0..0583e7f 100644
--- a/modules/gui/macosx/intf.m
+++ b/modules/gui/macosx/intf.m
@@ -1565,6 +1565,17 @@ static void manage_cleanup( void * args )
         p_intf->p_sys->b_intf_update = true;
         p_intf->p_sys->b_input_update = false;
         [self setupMenus]; /* Make sure input menu is up to date */
+
+        /* update our info-panel to reflect the new item, if we don't show
+         * the playlist or the selection is empty */
+        if( [self isPlaylistCollapsed] == YES )
+        {
+            playlist_t * p_playlist = pl_Hold( p_intf );
+            PL_LOCK;
+            [[self info] updatePanelWithItem: playlist_CurrentPlayingItem( p_playlist )->p_input];
+            PL_UNLOCK;
+            pl_Release( p_intf );
+        }
     }
     if( p_intf->p_sys->b_intf_update )
     {
@@ -1594,15 +1605,6 @@ static void manage_cleanup( void * args )
                 b_buffering = YES;
             }
 
-            /* update our info-panel to reflect the new item, if we don't show
-             * the playlist or the selection is empty */
-            if( [self isPlaylistCollapsed] == YES )
-            {
-                PL_LOCK;
-                [[self info] updatePanelWithItem: playlist_CurrentPlayingItem( p_playlist )->p_input];
-                PL_UNLOCK;
-            }
-
             /* seekable streams */
             b_seekable = var_GetBool( p_input, "can-seek" );
 
@@ -1696,6 +1698,7 @@ static void manage_cleanup( void * args )
             [[o_controls voutView] updateTitle];
  
             [o_playlist updateRowSelection];
+
             p_intf->p_sys->b_current_title_update = FALSE;
         }