[vlc-devel] commit: Actually initialize media_list_player ( Rémi Denis-Courmont )

Rémi Denis-Courmont remi at remlab.net
Fri May 22 08:26:08 CEST 2009


On Thu, 21 May 2009 14:42:14 -0700, "Pierre d'Herbemont"
<pdherbemont at free.fr> wrote:
>> diff --git a/src/control/media_list_player.c
> b/src/control/media_list_player.c
>> index d5865d9..fd9f2c2 100644
>> --- a/src/control/media_list_player.c
>> +++ b/src/control/media_list_player.c
>> @@ -264,10 +264,13 @@ libvlc_media_list_player_new( libvlc_instance_t *
> p_instance,
>>     if( !p_mlp )
>>         return NULL;
>>
>> +    libvlc_retain( p_instance );
>> +    p_mlp->p_libvlc_instance = p_instance;
>> +    p_mlp->i_refcount = 0;
> 
> Refcount shall be 1, not 0.

It makes sense. But this far it was more likely to be zero and any other
value since it was not initialized.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list