[vlc-devel] commit: XCB: memory leak ( Rémi Denis-Courmont )

git version control git at videolan.org
Sat May 23 15:55:00 CEST 2009


vlc | branch: 1.0-bugfix | Rémi Denis-Courmont <remi at remlab.net> | Sat May 23 16:49:58 2009 +0300| [c9064d52316709413e48578d6e5e6ca334b0d1e9] | committer: Rémi Denis-Courmont 

XCB: memory leak

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c9064d52316709413e48578d6e5e6ca334b0d1e9
---

 modules/video_output/xcb/xvideo.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index 0e99035..5b32ad1 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -159,12 +159,16 @@ static int Open (vlc_object_t *obj)
     /* Connect to X */
     p_sys->conn = Connect (obj);
     if (p_sys->conn == NULL)
+    {
+        free (p_sys);
         return VLC_EGENERIC;
+    }
 
     if (!CheckXVideo (vout, p_sys->conn))
     {
         msg_Warn (vout, "Please enable XVideo 2.2 for faster video display");
         xcb_disconnect (p_sys->conn);
+        free (p_sys);
         return VLC_EGENERIC;
     }
 
@@ -173,6 +177,7 @@ static int Open (vlc_object_t *obj)
     if (p_sys->embed == NULL)
     {
         xcb_disconnect (p_sys->conn);
+        free (p_sys);
         return VLC_EGENERIC;
     }
 




More information about the vlc-devel mailing list