[vlc-devel] commit: CMML: do not (ab)use the interface subsystem ( Rémi Denis-Courmont )
git version control
git at videolan.org
Sat May 23 20:18:17 CEST 2009
vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat May 23 18:50:15 2009 +0300| [94324e9f61a5733f1f682f333001af82f733b283] | committer: Rémi Denis-Courmont
CMML: do not (ab)use the interface subsystem
Only the core can safely destroy an interface, otherwise, the other
component could race against the core in joining the interface thread
or destroying the interface object.
The fire and forget status of interfaces is by design, and is expected
by -at least- the VLC binary, the NT service plugin and the Remote
Control interface plugin. Anyway, that is pretty the only point of
creating an interface instead of a private thread/object.
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=94324e9f61a5733f1f682f333001af82f733b283
---
modules/codec/cmml/cmml.c | 34 ++----------------
modules/codec/cmml/intf.c | 86 ++++++++++++++++++++++-----------------------
2 files changed, 46 insertions(+), 74 deletions(-)
Diff: http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=94324e9f61a5733f1f682f333001af82f733b283
More information about the vlc-devel
mailing list