[vlc-devel] [PATCH]-- correct snapshot aspect ratio (trac#2705)

brezhoneg1 brezhoneg1 at yahoo.fr
Mon May 25 14:09:28 CEST 2009

This patch corrects trac #2705 (snapshot aspect ratio problem)

Several issues have been discovered:

Patch1: solve a conflict between the snapshot plugin and the core

A snapshot plugin exists (module/video_ouput/snapshot.c).
This plugin conflicts with the core w.r.t "snapshot-width" and
"snapshot-height" variables. If this module is present, its default
values 320x200 take over the default values set by the core -1 x -1 .
These 320x200 values are a bit unfortunate, because it forces an aspect
ratio (16/10) that may not be the one really in use.

patch1 just renames all "snapshot-xxx" variables belonging to the vout
snapshot module into "snapmod-xxx" and reserved "snapshot-xxx" for the
vlc core.  Is it much used anyway ?

Patch2: really implements what the help says 

   help (vlc -H) announces the following about snapshot-width and height

     value -1 means original size (default values)
     value 0 means automatically scaling one direction w.r.t the other

   In addition, "sar_num" and "sar_den" in video_format_t are not set
automatically. This patch just sets them on the fly (video_output.c).
Maybe, they should be taken care of earlier in the process.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-snapshot-vout-plugin-avoid-variables-conflicting-w.patch
Type: application/octet-stream
Size: 6929 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090525/5c78ab85/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-snapshot-core-correct-aspect-ratio-issue-trac-2.patch
Type: application/octet-stream
Size: 3449 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090525/5c78ab85/attachment-0001.obj>

More information about the vlc-devel mailing list