[vlc-devel] commit: Compile fix on windows -- vlc_mutex_init() now returns void. ( JP Dinger )

Anthony Loiseau thannoy at actech-innovation.com
Mon May 25 14:57:32 CEST 2009


Just as a note/comment, I found weird that *p_sys is no more set with
this fix. But I am not skilled at all in this part of the source-code.


Regards,
Anthony

On Mon, 2009-05-25 at 14:40 +0200, git version control wrote:
> vlc | branch: master | JP Dinger <jpd at videolan.org> | Mon May 25 14:38:34 2009 +0200| [ba8f1f35e809572fb556818662bdf531a8a1c79a] | committer: JP Dinger 
> 
> Compile fix on windows -- vlc_mutex_init() now returns void.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ba8f1f35e809572fb556818662bdf531a8a1c79a
> ---
> 
>  include/vlc_gcrypt.h |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/include/vlc_gcrypt.h b/include/vlc_gcrypt.h
> index cd5ffd5..db054f4 100644
> --- a/include/vlc_gcrypt.h
> +++ b/include/vlc_gcrypt.h
> @@ -44,12 +44,8 @@ static int gcry_vlc_mutex_init( void **p_sys )
>      if( p_lock == NULL)
>          return ENOMEM;
>  
> -    i_val = vlc_mutex_init( p_lock );
> -    if( i_val )
> -        free( p_lock );
> -    else
> -        *p_sys = p_lock;
> -    return i_val;
> +    vlc_mutex_init( p_lock );
> +    return VLC_SUCCESS;
>  }
>  
>  static int gcry_vlc_mutex_destroy( void **p_sys )
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel




More information about the vlc-devel mailing list