[vlc-devel] [PATCH]-- correct snapshot aspect ratio (trac#2705)

Laurent Aimar fenrir at via.ecp.fr
Mon May 25 20:46:08 CEST 2009


On Mon, May 25, 2009, brezhoneg1 wrote:
> This patch corrects trac #2705 (snapshot aspect ratio problem)
> Several issues have been discovered:
> Patch1: solve a conflict between the snapshot plugin and the core
> -----------------------------------------------------------------
> A snapshot plugin exists (module/video_ouput/snapshot.c).
> This plugin conflicts with the core w.r.t "snapshot-width" and
> "snapshot-height" variables. If this module is present, its default
> values 320x200 take over the default values set by the core -1 x -1 .
> These 320x200 values are a bit unfortunate, because it forces an aspect
> ratio (16/10) that may not be the one really in use.
> patch1 just renames all "snapshot-xxx" variables belonging to the vout
> snapshot module into "snapmod-xxx" and reserved "snapshot-xxx" for the
> vlc core.  Is it much used anyway ?
 I think I would prefer using --vout-snapshot-* to comply a bit more with
what we (sometimes) do for new module options (--type-name-arg).
 What others think ?

 Except *maybe* that, it is fine.

> Patch2: really implements what the help says 
> --------------------------------------------
>    help (vlc -H) announces the following about snapshot-width and height
> :
>      value -1 means original size (default values)
>      value 0 means automatically scaling one direction w.r.t the other
>    In addition, "sar_num" and "sar_den" in video_format_t are not set
> automatically. This patch just sets them on the fly (video_output.c).
 It is fine.

> Maybe, they should be taken care of earlier in the process.
 Yes, but well the vout is in a bad shape. I am working on it and hope
to fixe some of its issues.

(As courmish said, could you rebase it against 1.0 ?)


More information about the vlc-devel mailing list