[vlc-devel] commit: Revert "correct realloc() usage, on failure realloc will return NULL" ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon May 25 17:42:04 2009 +0300| [30ceb37fe8d1cacb6f8fac51f9c1a2a58d324ca0] | committer: Rémi Denis-Courmont 

Revert "correct realloc() usage, on failure realloc will return NULL"

Brought to you by M2X. Needless to mention that this is complete 100%
crap. Depending cases, it's not either ignoring errors (and e.g. leaking
memory which is very stupid in OOM situations), or worse, introducing
bugs in places where realloc() was used correctly.

And exactly one day after I WARNED EXPLICITLY AGAINST DOING THIS.

This reverts commit ec5d86115480e2ba0f3b36b11c19570cbc75aa51.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=30ceb37fe8d1cacb6f8fac51f9c1a2a58d324ca0
---

 src/control/media_list_path.h |   11 +++--------
 src/extras/libc.c             |    4 +---
 src/input/es_out.c            |   25 +++++++++----------------
 src/input/input.c             |   20 ++++++++------------
 src/input/stream.c            |   24 ++++++++----------------
 src/input/vlmshell.c          |    6 +-----
 src/modules/entry.c           |    2 +-
 src/modules/modules.c         |    7 ++-----
 src/network/acl.c             |    3 +--
 src/network/httpd.c           |    9 ++-------
 src/network/io.c              |    9 +--------
 src/playlist/fetcher.c        |    6 ++----
 src/text/strings.c            |   24 +++++++-----------------
 13 files changed, 46 insertions(+), 104 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=30ceb37fe8d1cacb6f8fac51f9c1a2a58d324ca0