[vlc-devel] [PATCH] Add deinterlacing to libvlc, moz-plugin and activeX

[Laurent Aimar]

Hi,

On Thu, May 28, 2009, Cyril MATHE wrote:
> >  You should not modify "video-filter"/"vout-filter" directly for deinterlacing.
> > Doing so is
> >  - complicated because some deinterlacing mode does not work with
> >  "video-filter" as you noticed.
> >  - you simply broke the selection of current filter to replace it with none or
> >  deinterlacing (not what the function name says...).
> What do you mean by that ?
"video-filter" and "vout-filter" are not used only for deinterlacing.
For example, you can start vlc (or configure libvlc) with
--video-filter adjust.
With your function, as soon as you call it, the adjust filter will be
lost.

> >  In 1.1 (and for 1.0 I think), you can simply set "deinterlace" with the
> > mode you want on the vout object and everything should be taken care of.
> > (like var_SetString( p_vout, "deinterlace", psz_mode ))
> > 
> I try your solution but it doesn't work (I think that I already tried it
> in the past)
 Could you past the code you tried ?
Qt4 interface and the hotkeys module use it and it works well with them.
(you may have a look at modules/control/hotkeys.c:617 (or around).

-- 
fenrir